Vimc 8760: consider multi-cohort routine for vimpact as it pulls FVPs#43
Merged
pratikunterwegs merged 5 commits intomasterfrom Nov 6, 2025
Merged
Vimc 8760: consider multi-cohort routine for vimpact as it pulls FVPs#43pratikunterwegs merged 5 commits intomasterfrom
pratikunterwegs merged 5 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 60.73% 57.01% -3.73%
==========================================
Files 7 7
Lines 1062 1084 +22
==========================================
- Hits 645 618 -27
- Misses 417 466 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pratikunterwegs
left a comment
pratikunterwegs
left a comment
There was a problem hiding this comment.
Thanks - the changes look fine to me; just a few small comments. I haven't looked at the overall package so not commenting on anything else.
| disease_to_extract = c("COVID"), full_description = FALSE) | ||
| dat <- dat[dat$activity_type == "routine", ] | ||
|
|
||
| expect_false(length(unique(dat$age)) == 1L) |
kgaythorpe
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.